Our GitHub workflow for all client customizations & themes

Vanilla Forums
edited September 2016 in Dev & Ops

GitHub has given us the "Approval" option for PR reviews which nicely formalizes our existing process for client-approved customizations & themes.

Here's a quick review of what should be happening and how that fits into it:

  1. Create a branch from master.
  2. Create a PR against master & assign a reviewer.
  3. Reviewer & author go thru review.
  4. Reviewer approves PR.
  5. Author manually pulls PR to stage branch. (NOT a PR merge)
  6. Deploy to staging.
  7. Author makes further changes per client feedback.
  8. Client approves.
  9. [Reviewer re-approves if necessary.]
  10. Author merges approved PR.
  11. Deploy to production.

This should be the standard workflow for both VIP repos AND the clients repo. Note there is only 1 PR generated by each theme / feature review cycle.