Keystone is up on the staff forum
There are still a few issues to resolve with keystone before the public release, but I've gone ahead and enabled keystone one the staff forum. It's got a few variations but I've just got us using the default.
Feel free to leave feedback on this thread. @Isis and I have a bit to do this sprint, but we'd like to get any critical issues worked out before the release at the end of the month.
Notes
There are a few known bugs related to file attachments (including images). These are known and are being worked on. This is unrelated to the keystone theme.FixedRich Quotes are currently not appearing outside of the editor. A fix is underway.Fixed
Updates
Some style updates have come out now, resolving quite a few of the initially reported issues with styling on the category and discussion lists. Thanks @Isis
Comments
-
Is it me or is the text font too small?
5 -
Given that I am weirdo who sometimes goes here on my mobile this is most welcomed.
0 -
------------ IMAGE IN BETWEEN -------------
https://us.v-cdn.net/5022541/uploads/164/GZH25N69Y5YX.png-------------------------------------------------------
I tried to paste an image from the clipboard and it got uploaded properly but it's not showing
Finally... here is the image:
MY EYES!!
----------------
Edit: I created an issue about it https://github.com/vanilla/vanilla/issues/8227
0 -
On mobile the header looks weird.
0 -
https://us.v-cdn.net/5022541/uploads/928/UAECZZ02IEB2.png
Also, the sprocket icon on the top left corner of a post looks a bit off.
0 -
You mean this side panel?
You'll have to be more specific.
0 -
We didn't have our Mobile logo set. I've done it now.
0 -
Reaction glyph overlays are difficult to interpret.
https://us.v-cdn.net/5022541/uploads/855/XMF3QDUCHNBQ.png1 -
You're going to need to bug @Todd for this one.
Btw people, open issues pls! https://github.com/vanilla/vanilla/issues commenting here will not get those fixes done.
Make sure you start the issue Title with "Keystone: " and assign it to me so I can filter and find them when I go in a fixing spree.
1 -
This is what the activity page looks like to me.
0 -
Just taking a quick look now and not really bug hunting, but I really like it. It looks super clean.
1 -
I am curious how profile extender reacts with this theme. Can we add a few questions on this forum and test it out?
In fact, we might want to enable quite a few other addons that we might not use here but are very common with most of our instances to see how they play.
0 -
That's not a bad idea. This is essentially our smoke test at the moment.
Profile extender is already on though.
Title & Github are both profile extender fields. Any other ones you can think to turn on?
0 -
Seeing something has gone wrong on certain pages. This discussion cannot be loaded:
My comments page.
0 -
There seems to have been some data corruption in 1 particular post on your account on the 14th of January. With recent changes in our editor formatting pipeline it should not be possible for that to happen again. I've fixed it manually.
0 -
With recent changes in our editor formatting pipeline it should not be possible for that to happen again.
Perhaps some additional error handling, just in case? It'd be great to not crater a whole page over 1 body rendering issue.
0 -
I agree, everything is really difficult to read. And I'm wearing my glasses.
0 -
Maybe this is a coincidence, but I had the same issue with font size...then I realized I was zoomed at 80% for some reason. Now it looks fine.
0 -
That might explain it. The base font size on the keystone is the same as all the previous theme we were using on the staff forum, which is 14px. @Mel @Adrian Is there a particular element that seems small to you? The body content on keystone is 1px smaller than the previous theme we were using (14px now). Please double check your zoom.
0 -
@Adam Charron I would be curious what it looks like with a sort of "About Me" profile questions that we sometimes seem and how it handles line breaks and short answer type responses.
0 -
Zoom is at "actual size".
And apologies for the blanket statement here but it's pretty much all the words that look too small.
0 -
@Mel You'll have to bring that up with @Todd The 14px is by specification. Knowledge base is 16px, forum is 14px. In the meantime increasing your browser zoom by 10% for the staff forum should put things at a better size for you.
The styling works out, but I don't think ProfileExtender allows inputting line breaks without some custom work and keystone doesn't change that.
0 -
seems we are now missing link to KB in the header
0 -
Just noticed the best of page appears all broken - not sure why.
0 -
@BrendanParm Rich Editor has been broken on the best of page since it launched. I merged a fix earlier this week, but it hasn't been deployed yet.
Edit: I've redeployed the staff forum so that fix is now in effect. Post content properly displays on from rich editor in best of.
0 -
The Flag popup doesn't work. This was working in the previous release.
0
